fixed bug in CF where incorrect parameter was being passed to GNN.uti… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls.data_utils add_edges_to_nodes
pn51
reviewed
Oct 18, 2023
| @@ -460,7 +461,8 @@ def get_graph_for_simulation(self, traj_idx): | |||
| subtype_graph = transforms(subtype_graph) | |||
| elif graph_type in ["radius", "knn"]: | |||
| subtype_graph = add_edges_to_nodes( | |||
| subtype_graph, num_nodes, graph_type, radius=self.radius, k=self.k | |||
| subtype_graph, num_nodes, non_fluid_nodes, | |||
There was a problem hiding this comment.
non_fluid_nodes -> non_fluid_indices
pn51
requested changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ls.data_utils add_edges_to_nodes
Fixes/Addresses:
(replace this with the issue # fixed or addressed, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: