Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"NUL" is added when comparing a cloned empty file #17

Closed
Yaron10 opened this issue Mar 18, 2016 · 8 comments
Closed

"NUL" is added when comparing a cloned empty file #17

Yaron10 opened this issue Mar 18, 2016 · 8 comments

Comments

@Yaron10
Copy link

Yaron10 commented Mar 18, 2016

STR:

  1. Clone and Move to Other View a new empty file.
  2. Compare.

Result:
"NUL" is added to the files.


Originally opened in:
jsleroy/compare-plugin#8

See also:
https://notepad-plus-plus.org/community/topic/11307/plug-in-compare-bug/7

@pnedev
Copy link
Owner

pnedev commented Mar 19, 2016

Fixed in master branch:
bf8275f
Thanks.

BR

@pnedev pnedev closed this as completed Mar 19, 2016
@Yaron10
Copy link
Author

Yaron10 commented Mar 20, 2016

Hello Pavel,

A great job.

The crash in this case doesn't occur, but NUL is added.

Thank you very much.
BR.

@Yaron10
Copy link
Author

Yaron10 commented Mar 20, 2016

Hello again,

A crash does occur in the following case:

Start NPP.
Type something in New 1.
Open New 2.
Compare.

Thank you.

@pnedev
Copy link
Owner

pnedev commented Mar 20, 2016

Hello Yaron,

It should be OK now.
Could you test please?

BR

@Yaron10
Copy link
Author

Yaron10 commented Mar 20, 2016

Hello Pavel,

Solved. Thank you very much.

Could you please try the following steps?

Start NPP.
Open 2 new empty files.
Compare.

Result:
The second file is closed.

BR.

@Yaron10
Copy link
Author

Yaron10 commented Mar 21, 2016

Hello again,

Your fix is perfect.

Result:
The second file is closed.

This happens in previous versions as well.
Should I open a new issue for that?

Thank you.
BR

@pnedev
Copy link
Owner

pnedev commented Mar 22, 2016

Hello Yaron,

Yes, I've observed the same behavior but ignored it for now as it is not critical and high priority.
You can open new issue for that just to have this written and remember to fix it in the future.
Thanks.

BR

@Yaron10
Copy link
Author

Yaron10 commented Mar 22, 2016

Hello Pavel,

Thank you. I'll open a new issue.

BR

This was referenced May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants