Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Removed ability for a middle state to be a start/end state #30

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

jslane-h
Copy link
Collaborator

Straying a little away from the original intent of the ticket, this PR makes a user unable to change a middle state to a start/end state. The reason behind this is mostly because the GUI cannot support multiple root nodes (maybe we'd want this in the future?), and changing a middle state to a start/end state introduces an extra root node.

List of Changes:

  • Removed ability to change a middle state to a start/end state
  • Removed ability to set a "Choice"-type state to a start/end state
  • Refactored so that difference between advanced state forms, basic state forms, and general state forms is more obvious throughout the code
  • Removed logic of deleting a state out of the state item as a separation of concerns (states now signal to the workflow diagram that they are going to be deleted)
  • Added a context menu event so that you can right click a state and select edit instead of only allowing double click

@jslane-h jslane-h requested a review from lymereJ April 12, 2024 22:23
@jslane-h jslane-h self-assigned this Apr 12, 2024
@leijerry888 leijerry888 self-requested a review April 17, 2024 20:35
Copy link
Collaborator

@leijerry888 leijerry888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jslane-h , could you please merge develop in and resolve the conflicts

@jslane-h jslane-h marked this pull request as draft April 24, 2024 18:04
@jslane-h jslane-h marked this pull request as ready for review October 4, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants