-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spack buildcache to CPU Ubuntu builds #85
Conversation
Good to merge with an approving review. Note that this has moved our spack CPU build speeds down from 1.5hr to <20 mins |
Might be better for Jaelyn or Ryan to review this. I am not familiar with this stuff. |
https://asciinema.org/a/KCi5TmUXc6zWDj7JYHzfSFxmw - I need to update docs, but now installing exago based on these buildcaches takes <60 seconds :) |
f2597b9
to
d4a5f77
Compare
d4a5f77
to
97f2113
Compare
I took a sweep at the documentation and it 100% needs a review. We should probably replace some of my lazier language with just issue references and get more help cleaning up some of the things that are more out of date. @jaelynlitz since we are really pushing jupyter tutorials in the future, quarto will be really nice for sustainability, and making things prettier + easier to maintain. I think our pdf is probably extremely out of date in a few respects now. |
@abhyshr take a look at my documentation additions to the branch at least |
2374f93
to
f307957
Compare
Not sure this is the place for this comment, but there is a link in the buildsystem readme.md that points to gitlab which of course requires a login. Since this is a public repo should we refrain from linking to gitlab in our docs? It links to an old MR. |
broken link here as well https://github.com/pnnl/ExaGO/blob/spack-ubuntu-cache-dev/buildsystem/spack/README.md |
Broken links on this page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but does inspire a revamp of the old docs.
ebf7ef4
to
693cbed
Compare
If @jaelynlitz or @ryandanehy can approve (I need a re-review because I rebased), then this will auto merge when the pipeline succeeds |
I found that there is a 1,000 package limit but I haven't found that in documentation. Currently, ExaGO is the only package this org has though. I'm still looking into adding cleanup to the packages as well.
Thanks,
DJ
From: Cameron Rutherford ***@***.***>
Sent: Thursday, November 30, 2023 6:52 PM
To: pnnl/ExaGO ***@***.***>
Cc: DJ Moore ***@***.***>; Mention ***@***.***>
Subject: Re: [pnnl/ExaGO] Add Spack buildcache to CPU Ubuntu builds (PR #85)
Check twice before you click! This email originated from outside PNNL.
@DJ-pnnl<https://github.com/DJ-pnnl> is there a limit on the number of packages we can have? Do you know of easy ways to clean things out that might be older than n-weeks?
-
Reply to this email directly, view it on GitHub<#85 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXARDEFGU4W6KR2RFH6YQRTYHFA6ZAVCNFSM6AAAAAA7VL7PLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZVGM3TCOBUGY>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Merge request type
Relates to
This MR updates
Summary
Adds buildcache support for ExaGO Spack CPU builds. Should substantially speed up builds, and enable adding more of these builds in the future.