Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spack buildcache to CPU Ubuntu builds #85

Merged
merged 37 commits into from
Dec 4, 2023

Conversation

cameronrutherford
Copy link
Contributor

@cameronrutherford cameronrutherford commented Nov 22, 2023

Merge request type

  • New feature

Relates to

  • Spack configuration
  • Other

This MR updates

  • Spack configuration
  • Other

Summary

Adds buildcache support for ExaGO Spack CPU builds. Should substantially speed up builds, and enable adding more of these builds in the future.

@cameronrutherford
Copy link
Contributor Author

Good to merge with an approving review.

Note that this has moved our spack CPU build speeds down from 1.5hr to <20 mins

@abhyshr
Copy link
Collaborator

abhyshr commented Nov 22, 2023

Might be better for Jaelyn or Ryan to review this. I am not familiar with this stuff.

.github/workflows/spack_cpu_build.yaml Outdated Show resolved Hide resolved
.github/workflows/spack_cpu_build.yaml Outdated Show resolved Hide resolved
.github/workflows/spack_cpu_build.yaml Outdated Show resolved Hide resolved
.github/workflows/spack_cpu_build.yaml Show resolved Hide resolved
.github/workflows/spack_cpu_build.yaml Outdated Show resolved Hide resolved
@cameronrutherford
Copy link
Contributor Author

https://asciinema.org/a/KCi5TmUXc6zWDj7JYHzfSFxmw - I need to update docs, but now installing exago based on these buildcaches takes <60 seconds :)

@cameronrutherford
Copy link
Contributor Author

I took a sweep at the documentation and it 100% needs a review. We should probably replace some of my lazier language with just issue references and get more help cleaning up some of the things that are more out of date.

@jaelynlitz since we are really pushing jupyter tutorials in the future, quarto will be really nice for sustainability, and making things prettier + easier to maintain. I think our pdf is probably extremely out of date in a few respects now.

@cameronrutherford
Copy link
Contributor Author

@abhyshr take a look at my documentation additions to the branch at least

@ryandanehy
Copy link
Collaborator

Not sure this is the place for this comment, but there is a link in the buildsystem readme.md that points to gitlab which of course requires a login. Since this is a public repo should we refrain from linking to gitlab in our docs? It links to an old MR.

@ryandanehy
Copy link
Collaborator

ryandanehy commented Nov 29, 2023

Not sure this is the place for this comment, but there is a link in the buildsystem readme.md that points to gitlab which of course requires a login. Since this is a public repo should we refrain from linking to gitlab in our docs? It links to an old MR.

broken link here as well https://github.com/pnnl/ExaGO/blob/spack-ubuntu-cache-dev/buildsystem/spack/README.md

@ryandanehy
Copy link
Collaborator

Broken links on this page
https://github.com/pnnl/ExaGO/blob/spack-ubuntu-cache-dev/docs/exago_policy_compatibility.md
We might need to open PR later to deal with the revamp / refresh of the docs

ryandanehy
ryandanehy previously approved these changes Nov 29, 2023
Copy link
Collaborator

@ryandanehy ryandanehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but does inspire a revamp of the old docs.

@cameronrutherford
Copy link
Contributor Author

If @jaelynlitz or @ryandanehy can approve (I need a re-review because I rebased), then this will auto merge when the pipeline succeeds

@cameronrutherford cameronrutherford merged commit ae5c8ac into develop Dec 4, 2023
12 checks passed
@DJ-pnnl
Copy link

DJ-pnnl commented Dec 4, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPU only build of ExaGO in GitHub actions
5 participants