Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joss] Most operations fail on empty hypergraph #137

Open
szhorvat opened this issue Jan 17, 2024 · 1 comment
Open

[joss] Most operations fail on empty hypergraph #137

szhorvat opened this issue Jan 17, 2024 · 1 comment
Labels
active Work in progress joss

Comments

@szhorvat
Copy link
Contributor

Describe the bug

Most operations fail on empty hypergraph.

To Reproduce

hh = hnx.Hypergraph()
hn.draw(hh) # errors
hh.is_connected() # errors
hh.bipartite() # errors

Almost all functions / methods I tried threw a non-intuitive error.

HNX 2.1.3

Ref openjournals/joss-reviews#6016
@szhorvat szhorvat mentioned this issue Jan 17, 2024
Open
@bonicim bonicim added the active Work in progress label Jan 17, 2024
@bonicim bonicim self-assigned this Jan 17, 2024
@bonicim bonicim added backlog and removed active Work in progress labels Jan 22, 2024
@bonicim bonicim removed their assignment Jan 22, 2024
@bonicim bonicim added the joss label Jan 22, 2024
bonicim added a commit that referenced this issue Feb 15, 2024
@bonicim
Pull request #137: Update installation instructions for widget
fac0670 
Merge in HYP/hypernetx from HYP-384-hnx-widget-not-rendering-on-jupyter-lab to develop

* commit '53dc408129d1fc2ea8bff3b9620589fe179c510c':
  Update installation instructions for widget
bonicim added a commit that referenced this issue Feb 15, 2024
@bonicim
Pull request #138: Hotfix/joss paper
87be2bc 
Merge in HYP/hypernetx from hotfix/joss-paper to master

* commit '3c14988c6b93571fcab8696a324624d75c1a01e7':
  bump: version 2.1.3 → 2.1.4
  Update widget instructions; add screnshot
  Add Discussions section
  Update contributing authors
  HYP-389 Remove testing dependency; update test
  HYP-389 Fix optional dependencies; update documentation
  Pull request #137: Update installation instructions for widget
  HYP-391 Update Contributing guide
  HYP-392 Update post-installation steps documentation
bonicim added a commit that referenced this issue Feb 28, 2024
@bonicim @brendapraggastis
Pull request #137: Update installation instructions for widget
90ab39a 
Merge in HYP/hypernetx from HYP-384-hnx-widget-not-rendering-on-jupyter-lab to develop

* commit '53dc408129d1fc2ea8bff3b9620589fe179c510c':
  Update installation instructions for widget
@bonicim
Copy link
Collaborator

bonicim commented Jun 6, 2024

v2.3.2 addresses the non-intuitive errors for hnx.draw() and Hypergraph.bipartite()`.

On an empty hypergraph, hnx.draw() will draw a blank graph. No error is raised; Hypergraph.bipartite() will return an empty networkx graph.

hh.is_connected() will be addressed in a future patch release.

@bonicim bonicim added active Work in progress and removed backlog labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
active Work in progress joss
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szhorvat @bonicim