adding Conductance #122
Closed
adding Conductance #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing, @uninicol. Will review this with the team later today. |
|
@ftheberge This PR adds a |
|
Conductance is a useful measure, ok with me.
I assume you are also looking at the latest changes I shared with Brenda
last September?:
https://github.com/ftheberge/HyperNetX/tree/modularity
Cheers,
Francois T.
Le mer. 25 oct. 2023, à 18 h 15, Mark Bonicillo ***@***.***>
a écrit :
… @ftheberge <https://github.com/ftheberge> This PR adds a conductance
method to your hypergraph_modularity module. What is your feedback on this?
Is it good to go to be included?
—
Reply to this email directly, view it on GitHub
<#122 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFEKTEVSP65KME3DFKDEDTYBGFPLAVCNFSM6AAAAAA52CLLRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBQGEZTCMJVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
bonicim
added a commit
that referenced
this pull request
Nov 3, 2023
Merge in HYP/hypernetx from fix-ci-pipeline-docs to develop * commit '5c4b5183b944cd7bf7dccc54f45e5f71002ee01f': Update nb2plots
|
@uninicol @ftheberge I have an internal pull request (non-Github) that will merge both of your branches into master. Once merged, I will close this PR. |
|
Closing this PR because this working branch has been reviewed internally and merged into master and the latest release, 2.1. Thanks for the contribution @NicolBuratti @uninicol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding conductance method on ./hypernetx/algorithms/hypergraph_modularity.py with test. the code is translated from SimpleHypergraphs.jl Julia package