Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Review: simplify and update figure 2 in paper #15

Merged
merged 2 commits into from
May 26, 2022

Conversation

kmongird
Copy link
Contributor

Purpose:

JOSS Review:
Additional comment added by reviewer: "The diagram shown Fig. 2 is quite complicated and it is not easy to relate it to the text you added in this section. I think it might be simplified to better show the link with the text (you have numbers in the text which can not be found in the figure for example)"

Related:

Review openjournals/joss-reviews#4336

Resolved:

Resolve #8

@codecov-commenter
Copy link

Codecov Report

Merging #15 (a257df8) into main (84be817) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files          15       15           
  Lines        3392     3392           
=======================================
  Hits         2953     2953           
  Misses        439      439           
Flag Coverage Δ
unittests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84be817...a257df8. Read the comment docs.

@kmongird kmongird merged commit dec6871 into main May 26, 2022
@kmongird kmongird deleted the JOSS-review-update-figure branch May 26, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JOSS review: Software paper organization
2 participants