-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Birmiwal.rahul development #107
Conversation
…neuromancer into birmiwal.rahul_development
…neuromancer into birmiwal.rahul_development
Is the |
…or isolated graph to match new show() in system on develop branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicely done!
Made some additional changes to test_system.py and system.py. Added in output correctness check to MovingHorizon forward. Also modified associated docstring in system.py. The output should indeed be of dimension [ndelay, batch, data_dim]. One can confirm this by running:
should print torch.size([5,3,1]) |
This branch contains updates that incorporate the following desired tasks:
These files are test_system.py, test_problem.py, .github/workflows/update_docs.yml, /docs/readme.md
There is an update to the readme in /docs to reflect the change in documentation update.
There is also a one-line change to the docstring of System's MovingHorizon class (system.py) -- correcting an error that the output should be a 3D tensor of shape (ndelay, batch, dim)