This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Adding authentication cookies for SPO Admin domain #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…APIs on both domains to be called
KoenZomers
changed the title
Closed
7 tasks
|
Thanks @KoenZomers , simple and good fix for a problem that initially seemed more complex! |
|
@jansenbe Indeed, not too bad :) Only downside of this solution is that it will not work for dvNext enhanced tenants with vanity domains. Not sure how many of those we still have around anyway. Do you have some insight into this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
In PnP PowerShell, when using
Connect-PnPOnline -Url https://tenant.sharepoint.com -WebLoginand then running a PnPAdminCmdlet such asGet-PnPTenant, it would throw a 401 access denied as it doesn't have the FedAuth cookie for the tenant-admin.sharepoint.com domain. With this update, when connecting, it will add the FedAuth cookie for both the tenant.sharepoint.com as well as for the tenant-admin.sharepoint.com domains so the PnPAdminCmdlets will auto elevate and work correctly.