Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements: m365 pa app list #2872

Closed
appieschot opened this issue Dec 13, 2021 · 4 comments
Closed

Enhancements: m365 pa app list #2872

appieschot opened this issue Dec 13, 2021 · 4 comments

Comments

@appieschot
Copy link
Member

appieschot commented Dec 13, 2021

Enhance the m365 pa app list command with a option to specify the environment using following option:

-e, --environment [environment]

Implement in code using the following statement in the get request:

https://{powerAppsEndpoint}/providers/Microsoft.PowerApps/scopes/admin/environments/{environment}/)'

Enhance the m365 pa app list command with a option to retrieve data as admin :

--asAdmin

Implement in code using the following statement in the get request:
../providers/Microsoft.PowerApps/scopes/admin/..

@appieschot
Copy link
Member Author

@pnp/cli-for-microsoft-365-maintainers if would implement the same logic for as we did for Flow we would have to make the environment property required. However that would introduce a breaking change. I opt for implementing it as an optional parameter to keep current scripts and scenario's in place, and as part of our efforts for V4/V5 we could introduce a single m365 pp environment list implementation, and if in place make this property required. Please let me know if you feel differently.

appieschot added a commit to appieschot/cli-microsoft365 that referenced this issue Dec 13, 2021
appieschot added a commit to appieschot/cli-microsoft365 that referenced this issue Dec 13, 2021
@waldekmastykarz
Copy link
Member

What if we introduced the pp environment list command now, deprecate the flow environment list command and remove it in v6 (as v5 is just a few months away)?

@appieschot
Copy link
Member Author

appieschot commented Dec 14, 2021

What if we introduced the pp environment list command now,

Great idea, agree.

deprecate the flow environment list command

Not 100% sure if we can deprecate both (flow and pa environment list) it looks like there still is a Get-PowerAppEnvironment and Get-FlowEnvironment set of PS commands that look to act slightly different as they call different endpoints (not sure why)..

and remove it in v6 (as v5 is just a few months away)?

Agree

@waldekmastykarz
Copy link
Member

Not 100% sure if we can deprecate both (flow and pa environment list) it looks like there still is a Get-PowerAppEnvironment and Get-FlowEnvironment set of PS commands that look to act slightly different as they call different endpoints (not sure why)..

That's odd. Ideally, we'd figure it out to avoid offering our users ambiguous choices. Can you see any differences in the data you retrieve from these different APIs?

@waldekmastykarz waldekmastykarz added this to the v4.3 milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants