New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extends "spo site recyclebinitem restore" command with support to restore all items from site recycle bin. Closes #4726 #5538

Closed

nanddeepn wants to merge 20 commits into pnp:main from nanddeepn:issue-4726

Contributor

nanddeepn commented Oct 2, 2023

Extends spo site recyclebinitem restore command with support to restore all items from site recycle bin. Closes #4726

😍 Happy Hacktoberfest !


          restore all items from site recycle bin

3ac9e7e

Jwaegebaert added the hacktoberfest-accepted label

Contributor

Jwaegebaert commented Oct 2, 2023

Awesome job, we'll try te review it ASAP.

Jwaegebaert removed the hacktoberfest-accepted label

milanholemans self-assigned this

milanholemans requested changes

View reviewed changes

Contributor

milanholemans left a comment

Sorry for the super late review @nanddeepn. I was hoping to review these PRs sooner but to no avail. Apologies for this.

I made a few comments that we should solve before we merge this. Could have take a look at them, please? Thanks!

docs/docs/cmd/spo/site/site-recyclebinitem-restore.mdx Outdated Show resolved Hide resolved

docs/docs/cmd/spo/site/site-recyclebinitem-restore.mdx Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Outdated Show resolved Hide resolved

milanholemans marked this pull request as draft

December 15, 2023 20:46

nanddeepn added 3 commits

December 17, 2023 18:00


          review comments

e37cc14


          review comments

2e72b1c


          Update site-recyclebinitem-restore.spec.ts

31e8adc

nanddeepn marked this pull request as ready for review

December 18, 2023 13:54

milanholemans marked this pull request as draft

December 31, 2023 14:21

nanddeepn added 2 commits

January 2, 2024 12:34


          Update site-recyclebinitem-restore.spec.ts

71c2123


          Update site-recyclebinitem-restore.ts

8ea15f9

nanddeepn marked this pull request as ready for review

January 2, 2024 07:11

milanholemans requested changes

View reviewed changes

Contributor

milanholemans left a comment

Let's recheck a few important things before we proceed.

docs/docs/cmd/spo/site/site-recyclebinitem-restore.mdx Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Show resolved Hide resolved

milanholemans marked this pull request as draft

January 2, 2024 20:06

nanddeepn added 4 commits

January 3, 2024 09:54


          Update site-recyclebinitem-restore.mdx

084ee17


          Update site-recyclebinitem-restore.ts

b1fc177


          Update site-recyclebinitem-restore.spec.ts

27bf702


          Update site-recyclebinitem-restore.ts

715efa9

nanddeepn marked this pull request as ready for review

January 3, 2024 10:49

milanholemans requested changes

View reviewed changes

Contributor

milanholemans left a comment

I did another round of reviewing, I believe when these changes are implemented, we are almost there!
Thank you for being so patient, had to postpone this PR for a time due to lack of time.

docs/docs/cmd/spo/site/site-recyclebinitem-restore.mdx Outdated Show resolved Hide resolved

docs/docs/cmd/spo/site/site-recyclebinitem-restore.mdx Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Show resolved Hide resolved

milanholemans marked this pull request as draft

February 13, 2024 21:47

nanddeepn added 6 commits

February 16, 2024 14:04


          Update site-recyclebinitem-restore.mdx

26876a9


          Update site-recyclebinitem-restore.ts

2ae2c3f


          Update site-recyclebinitem-restore.spec.ts

a5dc93b


          Update site-recyclebinitem-restore.ts

9ad6288


          Update site-recyclebinitem-restore.mdx

8ec03c3


          Update site-recyclebinitem-restore.ts

0e6c16e

nanddeepn marked this pull request as ready for review

February 16, 2024 10:27

milanholemans requested changes

View reviewed changes

Contributor

milanholemans left a comment

The last mile, we're almost there. Found a few more small topics that we should fix before merging.

Thanks for perseverance.

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.spec.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Show resolved Hide resolved

milanholemans marked this pull request as draft

February 16, 2024 22:54

nanddeepn added 2 commits

February 18, 2024 15:08


          Update site-recyclebinitem-restore.ts

a6b9a17


          Update site-recyclebinitem-restore.spec.ts

4f6533b

nanddeepn marked this pull request as ready for review

February 18, 2024 09:50

milanholemans approved these changes

View reviewed changes

Contributor

milanholemans left a comment

Great work! The command looks ready.
Made a few tiny changes which I'll fix myself.

docs/docs/cmd/spo/site/site-recyclebinitem-restore.mdx Outdated Show resolved Hide resolved

docs/docs/cmd/spo/site/site-recyclebinitem-restore.mdx Outdated Show resolved Hide resolved

docs/docs/cmd/spo/site/site-recyclebinitem-restore.mdx Outdated Show resolved Hide resolved

docs/docs/cmd/spo/site/site-recyclebinitem-restore.mdx Outdated Show resolved Hide resolved

src/m365/spo/commands/site/site-recyclebinitem-restore.ts Outdated Show resolved Hide resolved

milanholemans and others added 2 commits

February 23, 2024 00:32


          Apply suggestions from code review

41c9c6e


          Merge branch 'main' into issue-4726

c32001a

milanholemans added the pr-merged label

Contributor

milanholemans commented Mar 18, 2024

Merged manually, thank you for this enhancement!

milanholemans closed this

nanddeepn deleted the issue-4726 branch

March 20, 2024 13:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels