-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extends "spo site recyclebinitem restore" command with support to restore all items from site recycle bin. Closes #4726 #5538
Conversation
Awesome job, we'll try te review it ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the super late review @nanddeepn. I was hoping to review these PRs sooner but to no avail. Apologies for this.
I made a few comments that we should solve before we merge this. Could have take a look at them, please? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's recheck a few important things before we proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did another round of reviewing, I believe when these changes are implemented, we are almost there!
Thank you for being so patient, had to postpone this PR for a time due to lack of time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last mile, we're almost there. Found a few more small topics that we should fix before merging.
Thanks for perseverance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! The command looks ready.
Made a few tiny changes which I'll fix myself.
Merged manually, thank you for this enhancement! |
Extends
spo site recyclebinitem restore
command with support to restore all items from site recycle bin. Closes #4726😍 Happy Hacktoberfest !