Includes response output: spo app until spo eventreceiver commands. Closes #3929 #5540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one! We'll try to review it ASAP. |
martinlingstuyl
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Hi @nanddeepn, neat work! I do have some minor comments, some of which need to be applied broader through the PR where necessary.
martinlingstuyl
added
the
hacktoberfest-accepted
martinlingstuyl
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Hi @nanddeepn, great work on the quick turnaround. I've made some last comments that I'll fix when merging.
|
Thanks @nanddeepn! That helps 😀 |
martinlingstuyl
approved these changes
Oct 4, 2023
|
Merged manually, thanks for contributing, you rock! 😊🌶️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes response output:
spo appuntilspo eventreceivercommands. Closes #3929😍 Happy Hacktoberfest !