PnPContext GetSiteCollectionManager().GetSiteCollectionsWithDetailsAsync(null, true) throwing exception

[valpvt]

Category

• Bug

Describe the bug

While using PnpContext GetSiteCollectionManager().GetSiteCollectionsWithDetailsAsync(null, true) the method is throwing an exception because a site collection is not retrieved (returned 404). This happens for deleted private channel sites (still in the recycle bin) because sites are still present in the SP hidden list used by the method

Steps to reproduce

Use GetSiteCollectionManager().GetSiteCollectionsWithDetailsAsync(null, true) after private channel sites were deleted

Expected behavior

This method should not return an exception for these deleted sites and simply ignore them.

Environment details (development & target environment)

DELETE THIS LINE BEFORE SUBMITTING - Complete the following (if ignored you'll be prompted for it before we can address your issue... save the time and provide it in your initial submission).

• SDK version: 1.10.0
• OS: W10
• SDK used in: Console App
• Framework: .NET 6.0
• Tooling: VS Code

Additional context

When you permanently delete the site form the recycle bin it solves the issue.
This issue is not present when using Get-PnpTenantSite -Detailed in PnP.PowerShell

Thanks for your contribution! Sharing is caring.

[jansenbe]

Thanks for the issue and associated PR @valpvt ! I'll have a look.

[jansenbe]

@valpvt : merged your fix, thanks for the contribution! Change will appear in the next nightly, closing this issue now.