Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong if condition combination & instead of && #911

Closed
1 task done
mr-sven opened this issue Jun 30, 2022 · 2 comments
Closed
1 task done

Wrong if condition combination & instead of && #911

mr-sven opened this issue Jun 30, 2022 · 2 comments
Assignees
@jansenbe
Labels
area: framework ⚙ Changes in the SDK core framework code

Comments

@mr-sven
Copy link

mr-sven commented Jun 30, 2022

Category

  • Bug

Describe the bug

For security checks I need to run code anaylses with sonarCube and the following blocker issue found:

pnpcore/src/sdk/PnP.Core/QueryModel/Model/BaseQueryableDataModelCollection.cs

Line 86 in bf1985c

if (provider != null & Expression != null)

Fix:

if (provider != null && Expression != null)

Steps to reproduce

Syntax error
@jansenbe
Copy link
Contributor

@mr-sven : nice catch!

@jansenbe jansenbe self-assigned this Jun 30, 2022
@jansenbe jansenbe added the area: framework ⚙ Changes in the SDK core framework code label Jun 30, 2022
@jansenbe
Copy link
Contributor

Fixed

jansenbe added a commit that referenced this issue Jun 30, 2022
@jansenbe
Fix: Wrong if condition combination & instead of && in `BaseQueryable…
8b52e7f 
…DataModelCollection` method `GetAsyncEnumerator` #911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansenbe jansenbe

Labels
area: framework ⚙ Changes in the SDK core framework code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jansenbe @mr-sven