Bug: Getting pages with ".aspx" in file name fails

[heinrich-ulbricht]

Category

• Bug

Describe the bug

Assume a page with the following file name: Test-NewForm.aspx---Some-information.aspx

This page cannot be retrieved properly. I encountered this when trying to provision such a page which threw at a strange location.

The root cause lies here:

pnpcore/src/sdk/PnP.Core/Model/SharePoint/Pages/Internal/Page.cs

Lines 279 to 282 in fcb531b

	if (pageName.EndsWith(".aspx"))
	{
	pageName = pageName.Replace(".aspx", "");
	}

This code removes every occurrence of ".aspx" in the file name while it should only remove the last ".aspx".

So the current behavior is:

• "Test-NewForm.aspx---Some-information.aspx" changes to "Test-NewForm---Some-information"

While it should be:

• "Test-NewForm.aspx---Some-information.aspx" changes to "Test-NewForm.aspx---Some-information"

Steps to reproduce

• create a page with the file name "Test-NewForm.aspx---Some-information.aspx"
• try a Web.GetPagesAsync("Test-NewForm.aspx---Some-information.aspx")

It fails to get the page, although it is there.

Expected behavior

It should detect pages with ".aspx" as part of the file name.

Environment details (development & target environment)

CURRENT :)

[jansenbe]

Thanks for reporting this one @heinrich-ulbricht , clearly a bug. I'll work on a fix.

[jansenbe]

@heinrich-ulbricht : fixed, use the next nightly of PnP Core and PnP Framework to test.