Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to list, approve and deny service principal requests #1100

Merged
merged 6 commits into from
Feb 20, 2023

Conversation

mloitzl
Copy link
Contributor

@mloitzl mloitzl commented Feb 17, 2023

No description provided.

@jansenbe jansenbe self-assigned this Feb 17, 2023
@jansenbe jansenbe added area: model 📐 Related to the core SDK models area:admin 📜 Admin library related labels Feb 17, 2023
add documentation
add sync methods to IServicePrincipal
@codecov-commenter
Copy link

Codecov Report

Base: 82.42% // Head: 84.12% // Increases project coverage by +1.70% 🎉

Coverage data is based on head (d3618d6) compared to base (63545f3).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1100      +/-   ##
==========================================
+ Coverage   82.42%   84.12%   +1.70%     
==========================================
  Files         416      602     +186     
  Lines       28590    41250   +12660     
==========================================
+ Hits        23565    34702   +11137     
- Misses       5025     6548    +1523     
Impacted Files Coverage Δ
...re/Model/SharePoint/Changes/Internal/ChangeUser.cs 0.00% <0.00%> (-100.00%) ⬇️
...k/PnP.Core/Model/Teams/Internal/TeamChatMessage.cs 72.34% <0.00%> (-27.66%) ⬇️
...odel/Security/Internal/SharePointUserCollection.cs 78.78% <0.00%> (-21.22%) ⬇️
...ore.Auth/Utilities/ApplicationBuilderExtensions.cs 43.90% <0.00%> (-18.17%) ⬇️
.../SharePoint/Core/Internal/ContentTypeCollection.cs 84.69% <0.00%> (-15.31%) ⬇️
src/sdk/PnP.Core/Services/Core/TestManager.cs 53.19% <0.00%> (-14.71%) ⬇️
...PnP.Core.Admin/Model/Teams/Internal/TeamCreator.cs 76.19% <0.00%> (-14.29%) ⬇️
...e/Model/Teams/Internal/TeamChannelTabCollection.cs 87.92% <0.00%> (-12.08%) ⬇️
...k/PnP.Core/Model/SharePoint/Core/Internal/Field.cs 81.60% <0.00%> (-11.25%) ⬇️
.../Model/SharePoint/Core/Internal/ListItemVersion.cs 66.66% <0.00%> (-11.12%) ⬇️
... and 313 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mloitzl mloitzl marked this pull request as ready for review February 18, 2023 17:38
jansenbe added a commit that referenced this pull request Feb 20, 2023
@jansenbe jansenbe merged commit 764ed77 into pnp:dev Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:admin 📜 Admin library related area: model 📐 Related to the core SDK models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants