Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New approve permission api #1479

Merged
merged 15 commits into from
Aug 21, 2024
Merged

Conversation

mloitzl
Copy link
Contributor

@mloitzl mloitzl commented Jun 9, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 97.97980% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.91%. Comparing base (63545f3) to head (9f5c1af).
Report is 1998 commits behind head on dev.

Files Patch % Lines
...Admin/Model/SharePoint/Core/Internal/AppManager.cs 88.88% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1479      +/-   ##
==========================================
- Coverage   82.42%   81.91%   -0.51%     
==========================================
  Files         416      627     +211     
  Lines       28590    44069   +15479     
  Branches        0     4621    +4621     
==========================================
+ Hits        23565    36100   +12535     
- Misses       5025     6614    +1589     
- Partials        0     1355    +1355     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mloitzl mloitzl force-pushed the feature/new-approve-permission-api branch from 2f7b441 to 81f2f34 Compare June 24, 2024 05:22
@mloitzl mloitzl marked this pull request as ready for review July 9, 2024 06:35
@mloitzl
Copy link
Contributor Author

mloitzl commented Jul 15, 2024

@jansenbe Ready for Review 🧞‍♂️

@jansenbe
Copy link
Contributor

Sorry @mloitzl : I missed the read for review message during my summer break. I'll work on it soon. Thx for your great contributions, as always!

@jansenbe jansenbe self-assigned this Aug 21, 2024
jansenbe pushed a commit that referenced this pull request Aug 21, 2024
@jansenbe jansenbe merged commit 4dafa55 into pnp:dev Aug 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants