Bug - remove page name normalization #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This page name normalization is not correct. We should not assume that all pages with spaces in their name should be renamed. This causes issue between Core and Framework where Framework has no normalization and when it tries to load the list item or verify the page is created, it queries for the page with spaces, but the save method in Core always saves with replacing spaces with dashes. This also causes issues with links to pages throughout a template that have linked to a page with spaces in it's name. I believe this normalization was implimented without understanding implications. I feel that if SharePoint allows a user to rename a page to have spaces in the title, then PnP should respect this and not rename the file.
Sarah4x
changed the title
|
@Sarah4x : now that the work is done to handle special characters across PnP Core SDK doing this "normalization" indeed does not make much sense any more. I'll process this in the coming days. Thanks for sharing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page name normalization is not correct. We should not assume that all pages with spaces in their name should be renamed. This causes issue between Core and Framework too where Framework has no normalization and when it tries to load the file/list item or verify the page is created, it queries for the page with spaces. The save method in Core always saves with replacing spaces with dashes.
This also causes issues with links to pages throughout a template that have linked to the page with spaces in its name.
I believe this normalization was implemented without understanding the implications. I feel that if SharePoint allows a user to rename a page to have spaces in the file name - then PnP should respect this and not rename the file.
@jansenbe I'm curious to know your take on this?