Added missing properties to IFile #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ength, ServerRedirectedUrl, VroomDriveID, and VroomItemID.
|
Looks great @DaleyKD ! I'll process it in the coming days (OOF currently). Really appreciate you're helping improve PnP Core SDK! |
…nt. Not sure what actually causes it, though.
|
@jansenbe - Forgive me. I'm an absolute GitHub n00b (we use ADO TFS at work). I didn't realize doing another commit on my branch would add it to the PR. Honestly not sure what to do at this point. |
1 task
|
@jansenbe - Thank you VERY much for fixing my test cases; I'll use this as a template for the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I compared
IFiletoMicrosoft.SharePoint.Client.Fileto see what properties were missing. So I added the following:I don't know what
HasAlternateContentStreamsis, so I was unable to provide a comment for the property. I'm also not sure if I wrote the Tests properly.