Enhance apirequest to allow setting http-header #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2021 23:19
for BuildSharePointRestBatchRequestContent the IF-MATCH is general set to *
… for compare with existing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to do a Graph PATCH Request i needed the ability to pass in the IF-MATCH Header with the etag.
The enhancement allows this by adding a optional Dictionary to APIRequest and APICall which then will be respected in BuildMicrosoftGraphBatchRequestContent.
I did not change BuildSharePointRestBatchRequestContent as I could not see the benefit of doing so and
the IF-MATCH=* in SP-REST has already the todo flag set and will be quite a large change if etag should be respected by default.