Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with paging and double-query #486

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Fixed issue with paging and double-query #486

merged 2 commits into from
Jun 15, 2021

Conversation

PaoloPia
Copy link
Contributor

No description provided.

@PaoloPia PaoloPia requested a review from jansenbe June 15, 2021 16:24
@codecov-commenter
Copy link

Codecov Report

Merging #486 (15b807c) into dev (bc90620) will increase coverage by 6.16%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #486      +/-   ##
==========================================
+ Coverage   73.68%   79.84%   +6.16%     
==========================================
  Files         256      343      +87     
  Lines       19713    23205    +3492     
==========================================
+ Hits        14525    18528    +4003     
+ Misses       5188     4677     -511     
Impacted Files Coverage Δ
...ore.Auth/Utilities/ApplicationBuilderExtensions.cs 88.23% <ø> (ø)
...c/sdk/PnP.Core.Auth/Utilities/CredentialManager.cs 10.24% <20.00%> (-2.76%) ⬇️
...e.Auth/Public/InteractiveAuthenticationProvider.cs 70.00% <100.00%> (+3.80%) ⬆️
.../sdk/PnP.Core.Auth/Utilities/SecurityExtensions.cs 100.00% <100.00%> (+57.69%) ⬆️
.../PnP.Core.Auth/Utilities/X509CertificateUtility.cs 100.00% <100.00%> (+100.00%) ⬆️
...del/SharePoint/Core/Internal/FieldLocationValue.cs 0.00% <0.00%> (-36.07%) ⬇️
...P.Core/QueryModel/Query/BaseDataModelExtensions.cs 38.88% <0.00%> (-23.07%) ⬇️
.../Model/Teams/Internal/TeamChatMessageAttachment.cs 85.71% <0.00%> (-14.29%) ⬇️
....Core/QueryModel/Query/DataModelQueryTranslator.cs 77.61% <0.00%> (-7.11%) ⬇️
...sdk/PnP.Core/Model/Base/BaseDataModelCollection.cs 56.85% <0.00%> (-7.11%) ⬇️
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d4ae3...15b807c. Read the comment docs.

jansenbe added a commit that referenced this pull request Jun 15, 2021
@jansenbe jansenbe merged commit 2741d92 into pnp:dev Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants