Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs with more information regarding IQuerable. #660

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

s-KaiNet
Copy link
Collaborator

As part of #638 I added a new page with some examples and explanations of IQueryable behavior. Hope this helps folks to faster understand the pattern. Now we have a reference to that page from "Requesting model collections". The idea was to provide more information on what is IQueryable inside PnP Core SDK, when to use AsRequested (or when not to use it).

As part of #639 I updated XML comments in code to explicitly mention IQueryable implementation and put a link to the corresponding docs.

Maybe it's not ideal, but I'm happy to see any comments or suggestions in this area. This is my attempt to make documentation around IQueryable a bit better :)

Closes #639 Closes #638

…de comments to include links to the documentation.
@codecov-commenter
Copy link

Codecov Report

Merging #660 (65d501d) into dev (c13436b) will increase coverage by 7.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #660      +/-   ##
==========================================
+ Coverage   75.32%   82.42%   +7.09%     
==========================================
  Files         257      416     +159     
  Lines       19708    28590    +8882     
==========================================
+ Hits        14846    23565    +8719     
- Misses       4862     5025     +163     
Impacted Files Coverage Δ
...del/SharePoint/Core/Internal/FieldLocationValue.cs 0.00% <0.00%> (-35.49%) ⬇️
...ore.Auth/Utilities/ApplicationBuilderExtensions.cs 62.06% <0.00%> (-26.17%) ⬇️
...h/Public/UsernamePasswordAuthenticationProvider.cs 69.31% <0.00%> (-24.80%) ⬇️
...P.Core/QueryModel/Query/BaseDataModelExtensions.cs 38.88% <0.00%> (-23.07%) ⬇️
...k/PnP.Core/Model/Teams/Internal/TeamIdentitySet.cs 50.00% <0.00%> (-16.67%) ⬇️
src/sdk/PnP.Core/Utilities/StringExtensions.cs 85.07% <0.00%> (-14.93%) ⬇️
.../Model/Teams/Internal/TeamChatMessageAttachment.cs 85.71% <0.00%> (-14.29%) ⬇️
...nP.Core/Services/Core/Http/SharePointRestClient.cs 70.37% <0.00%> (-12.24%) ⬇️
...e/Model/SharePoint/Core/Internal/StorageMetrics.cs 77.77% <0.00%> (-9.73%) ⬇️
.../PnP.Core/QueryModel/Query/ExpressionExtensions.cs 91.30% <0.00%> (-8.70%) ⬇️
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 869600b...65d501d. Read the comment docs.

@jansenbe
Copy link
Contributor

Awesome!!! Thanks a ton @s-KaiNet 🚀🥇🎉💪🚀🎉

@jansenbe jansenbe self-assigned this Nov 25, 2021
jansenbe added a commit that referenced this pull request Nov 25, 2021
@jansenbe jansenbe merged commit 65d501d into pnp:dev Nov 25, 2021
@s-KaiNet s-KaiNet deleted the docs-updates branch November 27, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants