Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for browser-wasm when adding MicrosoftGraphClient #700

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

avuorine
Copy link

Fixes #699

@codecov-commenter
Copy link

Codecov Report

Merging #700 (76a8c52) into dev (63545f3) will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #700      +/-   ##
==========================================
+ Coverage   82.42%   82.84%   +0.42%     
==========================================
  Files         416      432      +16     
  Lines       28590    30115    +1525     
==========================================
+ Hits        23565    24949    +1384     
- Misses       5025     5166     +141     
Impacted Files Coverage Δ
...re/Model/SharePoint/Changes/Internal/ChangeUser.cs 0.00% <0.00%> (-100.00%) ⬇️
....Core/Exceptions/MicrosoftGraphServiceException.cs 80.00% <0.00%> (-20.00%) ⬇️
...PnP.Core.Admin/Model/Teams/Internal/TeamCreator.cs 76.19% <0.00%> (-14.29%) ⬇️
src/sdk/PnP.Core/Services/Core/TestManager.cs 54.94% <0.00%> (-12.96%) ⬇️
.../SharePoint/Core/Internal/ContentTypeCollection.cs 87.67% <0.00%> (-12.33%) ⬇️
.../Model/SharePoint/Core/Internal/ListItemVersion.cs 66.66% <0.00%> (-11.12%) ⬇️
...e/Model/SharePoint/Core/Internal/ListCollection.cs 82.12% <0.00%> (-9.09%) ⬇️
...P.Core/Services/Core/CSOM/Utils/CSOMFieldHelper.cs 80.61% <0.00%> (-7.81%) ⬇️
...el/SharePoint/Core/Internal/FieldLinkCollection.cs 93.47% <0.00%> (-6.53%) ⬇️
...e/Model/SharePoint/Core/Internal/FieldUserValue.cs 83.65% <0.00%> (-5.77%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27dbbb6...76a8c52. Read the comment docs.

@jansenbe jansenbe self-assigned this Dec 22, 2021
@jansenbe jansenbe added area: framework ⚙ Changes in the SDK core framework code bug Something isn't working labels Dec 22, 2021
jansenbe added a commit that referenced this pull request Dec 22, 2021
@jansenbe jansenbe merged commit 6d65679 into pnp:dev Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: framework ⚙ Changes in the SDK core framework code bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor wasm support broken in 1.5.0
3 participants