Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Navigation Model to IWeb #805

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

MathijsVerbeeck
Copy link
Contributor

Added base functionalities for #212

Web:

  • Add navigation nodes to the top navigation and quicklaunch
  • Delete all navigation nodes
  • Add child nodes
  • Move child nodes after a specific child node
  • Update existing navigation node

…n on the Web object and Quicklaunch navigation on the web object.
@codecov-commenter
Copy link

Codecov Report

Merging #805 (677a376) into dev (63545f3) will increase coverage by 0.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #805      +/-   ##
==========================================
+ Coverage   82.42%   83.30%   +0.88%     
==========================================
  Files         416      473      +57     
  Lines       28590    32496    +3906     
==========================================
+ Hits        23565    27071    +3506     
- Misses       5025     5425     +400     
Impacted Files Coverage Δ
...re/Model/SharePoint/Changes/Internal/ChangeUser.cs 0.00% <0.00%> (-100.00%) ⬇️
...odel/Security/Internal/SharePointUserCollection.cs 78.78% <0.00%> (-21.22%) ⬇️
....Core/Exceptions/MicrosoftGraphServiceException.cs 80.00% <0.00%> (-20.00%) ⬇️
...PnP.Core.Admin/Model/Teams/Internal/TeamCreator.cs 76.19% <0.00%> (-14.29%) ⬇️
src/sdk/PnP.Core/Services/Core/TestManager.cs 54.94% <0.00%> (-12.96%) ⬇️
.../SharePoint/Core/Internal/ContentTypeCollection.cs 87.67% <0.00%> (-12.33%) ⬇️
.../Model/SharePoint/Core/Internal/ListItemVersion.cs 66.66% <0.00%> (-11.12%) ⬇️
...e/Model/SharePoint/Core/Internal/ListCollection.cs 82.12% <0.00%> (-9.09%) ⬇️
...P.Core/Services/Core/CSOM/Utils/CSOMFieldHelper.cs 80.61% <0.00%> (-7.81%) ⬇️
...nP.Core/Model/Security/Internal/SharePointGroup.cs 61.97% <0.00%> (-6.28%) ⬇️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ae919...677a376. Read the comment docs.

@jansenbe jansenbe self-assigned this Mar 31, 2022
@jansenbe jansenbe added the area: model 📐 Related to the core SDK models label Mar 31, 2022
@jansenbe
Copy link
Contributor

Awesome work @MathijsVerbeeck !! Thanks for helping out growing PnP Core SDK 💪

@matsla
Copy link

matsla commented Apr 1, 2022

@jansenbe when will the added navigation model to IWeb be released?

@jansenbe
Copy link
Contributor

jansenbe commented Apr 1, 2022

@matsla , soon I hope, will try to process this one over the weekend or early next week.

jansenbe added a commit that referenced this pull request Apr 4, 2022
@jansenbe jansenbe merged commit 12bd238 into pnp:dev Apr 4, 2022
@jansenbe
Copy link
Contributor

jansenbe commented Apr 4, 2022

@MathijsVerbeeck : just merged this nicely implemented PR, well done! Thanks 🚀💪👍

@MathijsVerbeeck MathijsVerbeeck deleted the NavigationExtensionToWeb branch May 8, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: model 📐 Related to the core SDK models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants