Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capability to share folders using both links or by invite #841

Merged
merged 2 commits into from
May 6, 2022

Conversation

MathijsVerbeeck
Copy link
Contributor

Issue ref: #690

@jansenbe Thanks for assisting in obtaining the driveid / driveitemid 😃

@codecov-commenter
Copy link

Codecov Report

Merging #841 (5e93bb2) into dev (63545f3) will increase coverage by 1.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #841      +/-   ##
==========================================
+ Coverage   82.42%   83.50%   +1.08%     
==========================================
  Files         416      513      +97     
  Lines       28590    34584    +5994     
==========================================
+ Hits        23565    28879    +5314     
- Misses       5025     5705     +680     
Impacted Files Coverage Δ
...re/Model/SharePoint/Changes/Internal/ChangeUser.cs 0.00% <0.00%> (-100.00%) ⬇️
...odel/Security/Internal/SharePointUserCollection.cs 78.78% <0.00%> (-21.22%) ⬇️
....Core/Exceptions/MicrosoftGraphServiceException.cs 80.00% <0.00%> (-20.00%) ⬇️
...PnP.Core.Admin/Model/Teams/Internal/TeamCreator.cs 76.19% <0.00%> (-14.29%) ⬇️
src/sdk/PnP.Core/Services/Core/TestManager.cs 54.94% <0.00%> (-12.96%) ⬇️
.../Model/SharePoint/Core/Internal/SharePointAdmin.cs 81.06% <0.00%> (-12.80%) ⬇️
.../SharePoint/Core/Internal/ContentTypeCollection.cs 87.67% <0.00%> (-12.33%) ⬇️
...e/Model/Teams/Internal/TeamChannelTabCollection.cs 87.92% <0.00%> (-12.08%) ⬇️
.../Model/SharePoint/Core/Internal/ListItemVersion.cs 66.66% <0.00%> (-11.12%) ⬇️
...e/Model/SharePoint/Core/Internal/ListCollection.cs 82.12% <0.00%> (-9.09%) ⬇️
... and 178 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52ce85...5e93bb2. Read the comment docs.

jansenbe added a commit that referenced this pull request May 6, 2022
@jansenbe jansenbe merged commit f9cef17 into pnp:dev May 6, 2022
@jansenbe
Copy link
Contributor

jansenbe commented May 6, 2022

@MathijsVerbeeck : top quality on the PR !!

@MathijsVerbeeck MathijsVerbeeck deleted the sharefolders branch May 8, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants