Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed GraphGroup constructor from Internal to Public #845

Merged
merged 2 commits into from
May 10, 2022
Merged

Changed GraphGroup constructor from Internal to Public #845

merged 2 commits into from
May 10, 2022

Conversation

danielpastoor
Copy link
Contributor

Error when trying to get group data from a team site:
No parameterless constructor defined for type 'PnP.Core.Model.Security.GraphGroup'

Fix:
Change the constructor of GraphGroup from Internal to Public.

And added the documentation for the fixed part.

@jansenbe jansenbe self-assigned this May 10, 2022
@jansenbe jansenbe added area: documentation 📖 Improvements or additions to documentation area: model 📐 Related to the core SDK models labels May 10, 2022
@jansenbe
Copy link
Contributor

Nice catch on the constructor @danielpastoor , it was accidently left internal.

@codecov-commenter
Copy link

Codecov Report

Merging #845 (a836e7c) into dev (63545f3) will increase coverage by 0.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #845      +/-   ##
==========================================
+ Coverage   82.42%   83.29%   +0.86%     
==========================================
  Files         416      522     +106     
  Lines       28590    35034    +6444     
==========================================
+ Hits        23565    29180    +5615     
- Misses       5025     5854     +829     
Impacted Files Coverage Δ
...re/Model/SharePoint/Changes/Internal/ChangeUser.cs 0.00% <0.00%> (-100.00%) ⬇️
.../PnP.Core/Model/SharePoint/Core/Internal/Folder.cs 73.28% <0.00%> (-23.89%) ⬇️
...odel/Security/Internal/SharePointUserCollection.cs 78.78% <0.00%> (-21.22%) ⬇️
....Core/Exceptions/MicrosoftGraphServiceException.cs 80.00% <0.00%> (-20.00%) ⬇️
...PnP.Core.Admin/Model/Teams/Internal/TeamCreator.cs 76.19% <0.00%> (-14.29%) ⬇️
src/sdk/PnP.Core/Services/Core/TestManager.cs 54.94% <0.00%> (-12.96%) ⬇️
.../Model/SharePoint/Core/Internal/SharePointAdmin.cs 81.06% <0.00%> (-12.80%) ⬇️
.../SharePoint/Core/Internal/ContentTypeCollection.cs 87.67% <0.00%> (-12.33%) ⬇️
...e/Model/Teams/Internal/TeamChannelTabCollection.cs 87.92% <0.00%> (-12.08%) ⬇️
.../Model/SharePoint/Core/Internal/ListItemVersion.cs 66.66% <0.00%> (-11.12%) ⬇️
... and 193 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d0570...a836e7c. Read the comment docs.

jansenbe added a commit that referenced this pull request May 10, 2022
@jansenbe jansenbe merged commit a836e7c into pnp:dev May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Improvements or additions to documentation area: model 📐 Related to the core SDK models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants