Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get preview from IFile for embedding #885

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

MathijsVerbeeck
Copy link
Contributor

This PR closes a suggestion from #849 .

@MathijsVerbeeck MathijsVerbeeck changed the title Get preview from IFile object for embedding Get preview from IFile for embedding Jun 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #885 (9e02846) into dev (63545f3) will increase coverage by 1.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #885      +/-   ##
==========================================
+ Coverage   82.42%   83.56%   +1.14%     
==========================================
  Files         416      579     +163     
  Lines       28590    37522    +8932     
==========================================
+ Hits        23565    31355    +7790     
- Misses       5025     6167    +1142     
Impacted Files Coverage Δ
...re/Model/SharePoint/Changes/Internal/ChangeUser.cs 0.00% <0.00%> (-100.00%) ⬇️
...k/PnP.Core/Model/Teams/Internal/TeamChatMessage.cs 72.34% <0.00%> (-27.66%) ⬇️
...odel/Security/Internal/SharePointUserCollection.cs 78.78% <0.00%> (-21.22%) ⬇️
.../SharePoint/Core/Internal/ContentTypeCollection.cs 84.69% <0.00%> (-15.31%) ⬇️
...PnP.Core.Admin/Model/Teams/Internal/TeamCreator.cs 76.19% <0.00%> (-14.29%) ⬇️
src/sdk/PnP.Core/Services/Core/TestManager.cs 54.94% <0.00%> (-12.96%) ⬇️
.../Model/SharePoint/Core/Internal/SharePointAdmin.cs 81.06% <0.00%> (-12.80%) ⬇️
...e/Model/Teams/Internal/TeamChannelTabCollection.cs 87.92% <0.00%> (-12.08%) ⬇️
...k/PnP.Core/Model/SharePoint/Core/Internal/Field.cs 80.95% <0.00%> (-11.91%) ⬇️
.../Model/SharePoint/Core/Internal/ListItemVersion.cs 66.66% <0.00%> (-11.12%) ⬇️
... and 260 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff7b17...9e02846. Read the comment docs.

@jansenbe jansenbe self-assigned this Jun 20, 2022
@jansenbe jansenbe added the area: model 📐 Related to the core SDK models label Jun 20, 2022
@jansenbe jansenbe merged commit 7ccedb1 into pnp:dev Jun 20, 2022
@MathijsVerbeeck MathijsVerbeeck deleted the getfilepreview branch September 22, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: model 📐 Related to the core SDK models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants