Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search sort direction #937

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Search sort direction #937

merged 1 commit into from
Aug 22, 2022

Conversation

lroos
Copy link
Contributor

@lroos lroos commented Aug 11, 2022

Fixes a bug introduced by the switch from GET to POST search query by aligning the SortDirection enum with System.ComponentModel.ListSortDirection (Ascending = 0). This was previously passed as a string but POST model requires it as an int.

@jansenbe
Copy link
Contributor

Thanks for the fix @lroos 🚀👍

@jansenbe jansenbe self-assigned this Aug 22, 2022
@jansenbe jansenbe added the area: model 📐 Related to the core SDK models label Aug 22, 2022
@jansenbe jansenbe merged commit 9ae5767 into pnp:dev Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: model 📐 Related to the core SDK models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants