Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing property IsVisible property to AdaptiveCardAction #986

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

KoenZomers
Copy link
Contributor

The IsVisible property is missing on the AdaptiveCard causing an update to the adaptivecard using its typed properties to wipe out the action button on the card by having it default back to false visibility. Adding this property in fixes that.

@codecov-commenter
Copy link

Codecov Report

Base: 82.42% // Head: 84.08% // Increases project coverage by +1.65% 🎉

Coverage data is based on head (2ab4412) compared to base (63545f3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #986      +/-   ##
==========================================
+ Coverage   82.42%   84.08%   +1.65%     
==========================================
  Files         416      600     +184     
  Lines       28590    40092   +11502     
==========================================
+ Hits        23565    33710   +10145     
- Misses       5025     6382    +1357     
Impacted Files Coverage Δ
...re/Model/SharePoint/Changes/Internal/ChangeUser.cs 0.00% <0.00%> (-100.00%) ⬇️
...k/PnP.Core/Model/Teams/Internal/TeamChatMessage.cs 72.34% <0.00%> (-27.66%) ⬇️
...odel/Security/Internal/SharePointUserCollection.cs 78.78% <0.00%> (-21.22%) ⬇️
.../SharePoint/Core/Internal/ContentTypeCollection.cs 84.69% <0.00%> (-15.31%) ⬇️
...PnP.Core.Admin/Model/Teams/Internal/TeamCreator.cs 76.19% <0.00%> (-14.29%) ⬇️
...k/PnP.Core/Model/SharePoint/Core/Internal/Field.cs 80.18% <0.00%> (-12.68%) ⬇️
...e/Model/Teams/Internal/TeamChannelTabCollection.cs 87.92% <0.00%> (-12.08%) ⬇️
.../Model/SharePoint/Core/Internal/ListItemVersion.cs 66.66% <0.00%> (-11.12%) ⬇️
src/sdk/PnP.Core/Services/Core/TestManager.cs 57.14% <0.00%> (-10.76%) ⬇️
.../Model/SharePoint/Core/Internal/SharePointAdmin.cs 83.33% <0.00%> (-10.53%) ⬇️
... and 291 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

jansenbe added a commit that referenced this pull request Oct 7, 2022
@jansenbe jansenbe merged commit ac8a6c2 into pnp:dev Oct 7, 2022
@KoenZomers KoenZomers deleted the AddIsVisibleToAdaptiveCardAction branch October 8, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants