Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect type of data in progress method #3117

Closed
StanislauPranovich opened this issue Aug 14, 2024 · 2 comments · Fixed by #3122
Closed

incorrect type of data in progress method #3117

StanislauPranovich opened this issue Aug 14, 2024 · 2 comments · Fixed by #3122

Comments

@StanislauPranovich
Copy link

StanislauPranovich commented Aug 14, 2024

What version of PnPjs library you are using

4.x

Minor Version Number

4.4.0

Target environment

SharePoint Framework

Additional environment details

I'm using SPFx 1.19.0 and updated @pnp/sp 3.24.0 to 4.4.0.

Question/Request

Hi! I encountered an error.
In your package at /@pnp/sp/files/types.d.ts the following type is specified:

export interface IChunkedOperationProps {
progress: (data: IFileUploadProgressData) => void;
}

but in the documentation https://pnp.github.io/pnpjs/sp/files/#progress-function

data type is specified as ChunkedFileUploadProgressData.

Please, tell me what to do with this error?

@patrick-rodgers
Copy link
Member

Thanks - looks like we missed updating the docs for v4. Got it updated now.

Copy link

This issue is locked for inactivity or age. If you have a related issue please open a new issue and reference this one. Closed issues are not tracked.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants