Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DateTimePicker control #255

Closed
wants to merge 13 commits into from
Closed

Added DateTimePicker control #255

wants to merge 13 commits into from

Conversation

robert-lindstrom
Copy link
Contributor

Q A
Bug fix? [ ]
New feature? [x ]
New sample? [ ]
Related issues? fixes #21

What's in this Pull Request?

Added a DateTimePicker control that allows selecting date and time of day.

Features:

  • 12-hour or 24-hour time format
  • Optionally hide time inputs
  • Properties for use as controlled component (value and onChange)

Based on the PropertyFieldDateTimePicker from sp-dev-fx-property-controls.

@msftclas
Copy link

msftclas commented Mar 15, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

codecov-io commented Mar 15, 2019 •
edited
Loading

Codecov Report

Merging #255 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #255   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          16       16           
  Lines         744      744           
  Branches      138      138           
=======================================
  Hits          541      541           
  Misses        159      159           
  Partials       44       44
Impacted Files Coverage Δ
src/loc/en-us.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3481d...47a8fb1. Read the comment docs.

@robert-lindstrom
Rename FieldErrorMessage to ErrorMessage
e8fba3d 
This change aligns with pnp#240 by @AJIXuMuK
@robert-lindstrom
Add validation that was missing
a87fad2
@robert-lindstrom
Ensure dropdowns are updated if value changes
79d8d14
@robert-lindstrom
Extract dropdown options from render method
6be21f9 
Based on pnp#240 by @AJIXuMuK
@robert-lindstrom
Improve string handling
2e9da08 
- Implemented strings property allow passing in localize
  strings like DatePicker does it.
- Updated documentation with new property plus interfaces
  and enums used
@robert-lindstrom
Improve hours/minutes/seconds components
b89d8a1
@robert-lindstrom
Improve date convention handling
2a93894
@robert-lindstrom
Handle changes of value prop
755d2e5
@robert-lindstrom
Make label property optional.
e9f5668 
Aligns behavior with DatePicker.
@robert-lindstrom
Use flex instead of table layout
07149da 
Adapted from pnp#240 by @AJIXuMuK
@robert-lindstrom
Add showSeconds property to DateTimePicker
d86268d 
Based on pnp#240 by @AJIXuMuK. Changed default to false
i.e., to hide seconds dropdown since SharePoint historically
has not been showing seconds.
@robert-lindstrom
Add support for formatDate to DateTimePicker.
47a8fb1 
Based on pnp#240 by @AJIXuMuK
@robert-lindstrom robert-lindstrom mentioned this pull request Mar 22, 2019
Closed
@estruyf
Copy link
Member

estruyf commented Apr 9, 2019

@robert-lindstrom this has been merged to the DEV branch with "some" changes :-). Thanks for this great addition to the controls!

@estruyf estruyf closed this Apr 9, 2019
@estruyf estruyf added this to the 1.13.0 milestone Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@robert-lindstrom @msftclas @codecov-io @estruyf