Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker Sorting Does Not Work #487

Closed
1 of 3 tasks
HiltonGiesenow opened this issue Aug 31, 2022 · 1 comment
Closed
1 of 3 tasks

FilePicker Sorting Does Not Work #487

HiltonGiesenow opened this issue Aug 31, 2022 · 1 comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone

Comments

@HiltonGiesenow
Copy link
Contributor

Category

  • Enhancement
  • Bug
  • Question

Version

Please specify what version of the library you are using: [1.9.0]

Expected / Desired Behavior / Question

The FilePicker control should be able to sort on any of the columns it shows (name, modified date, modified by, size).

Observed Behavior

When using the FilePicker control, sorting works fine (for me) on the Modifed By column, but all other sorts don't work properly at all (they seem kind of random). Further, when I look at the code (e.g. https://github.com/pnp/sp-dev-fx-property-controls/blob/master/src/propertyFields/filePicker/filePickerControls/controls/FileBrowser/FileBrowser.tsx#L382) I can see there's no "same" condition handled (for instance see at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#description that 3 results are possible, not just greater than and less than but also equal to).

Steps to Reproduce

In the test harness, open the File Picker, browse to a folder, and try sort the items.

I'm working on a fix already, so hopefully this issue is just 'fyi'.

@ghost
Copy link

ghost commented Aug 31, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Aug 31, 2022
AJIXuMuK added a commit that referenced this issue Sep 24, 2022
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Triage 🔍 labels Sep 24, 2022
@AJIXuMuK AJIXuMuK added this to the 3.10.0 milestone Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

No branches or pull requests

2 participants