-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample gallery with extension type, Closes #219 #260
Sample gallery with extension type, Closes #219 #260
Conversation
e229636
to
ee0f3fe
Compare
Awesome ππππ I will review it ASAP π€© |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicodecleyre awesome work so far π
The implementation is really good and clean and I have only some small details I commented.
The biggest problem I noticed is a small bug that:
I managed to have the extension type filter present not only with extension component type but with webpart as well. Then I selected form customizer type and when I unselected and selected extension component type again it seemed that the form customizer extension type was already selected (the samples were filtered) but it wasn't selected in the picker. Please check the below recording for more details.
https://github.com/pnp/vscode-viva/assets/58668583/0866d980-6d59-4653-8183-745c901cb0eb
The aim is to add a preview feature with SPFx chat participant ![chat-intro](https://github.com/pnp/vscode-viva/assets/58668583/e4166cfc-b200-4563-88c9-a53f09add7f1) - [X] Added chat participant Related: pnp#239
43e46e8
to
6af7cf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicodecleyre the implementation looks ok but when testing it locally it seems like it is a bit inconsistent with the rest of filters and some behavior is still buggy
Please check below recording for more context.
PR.test.mp4
- it seems the selected extension type filter are not pointed out in the text box and the checkbox are not marked
- the picked option are not shown in the tag below as other filters
- when we 'clear all' the extension gets unselected but the extension type select gets not hidden
The aim is to add a preview feature with SPFx chat participant ![chat-intro](https://github.com/pnp/vscode-viva/assets/58668583/e4166cfc-b200-4563-88c9-a53f09add7f1) - [X] Added chat participant Related: pnp#239
69f8ce4
to
412d3b5
Compare
β¦github.com/nicodecleyre/vscode-viva into Sample-gallery-with-extension-type-pnp#219
Thx @Adam-it, indeed a bit inconsistent like you said. Did a couple of changes and tested. Seems to work fine on my end. Let me know if you find other bugs π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works really good π
Added some minor styling tweaks.
Awesome work π You Rock π€©
## π― Aim Adding an extra filter to Sample gallery so that we can filter on the extension type. Filter can only be visible when extension type is selected 'Component Type' ## π· Result ![image](https://github.com/pnp/vscode-viva/assets/35696168/c8c2e084-5831-4fc4-861e-ad4c4c0845d7) ## β What was done - [X] Added Extension filter dropdown - [X] Added functionality so that extension filter is only visible when extension is selected in the Component Type dropdown - [X] Added filter functionality so that samples get filtered based on selected value in extension dropdown - [x] Added filter functionality so that samples don't get filtered when extensions dropdown has selected values but extension is not selected in component type dropdown ## π Related issue Closes: #219
π― Aim
Adding an extra filter to Sample gallery so that we can filter on the extension type. Filter can only be visible when extension type is selected 'Component Type'
π· Result
β What was done
π Related issue
Closes: #219