Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(make-dedicated-lockfile): prepublishOnly script is automatically removed #5061

Closed
jjangga0214 opened this issue Jul 20, 2022 · 2 comments · Fixed by #5083
Closed

fix(make-dedicated-lockfile): prepublishOnly script is automatically removed #5061

jjangga0214 opened this issue Jul 20, 2022 · 2 comments · Fixed by #5083
Assignees
Milestone

Comments

@jjangga0214
Copy link

jjangga0214 commented Jul 20, 2022

pnpm version: 7.5.1

Code to reproduce the issue:

I am using pnpm within monorepo and workspace protocol.
When I use @pnpm/make-dedicated-lockfile, I faced a problem.

$ git clone git@github.com:jjangga0214/haetae.git
$ cd haetae 
$ git reset --hard 90c6718
$ pnpm install
$ pnpm add -wD @pnpm/make-dedicated-lockfile
$ cd packages/core
$ pnpm make-dedicated-lockfile

Expected behavior:

It creates pnpm-lock.yaml in packages/core.

Actual behavior:

As expected, it creates pnpm-lock.yaml in packages/core.
However, prepublishOnly script is automatically deleted from package.json.
I do not understand why. Is this a bug?

Thank you so much for pnpm.

Additional information:

  • node -v prints: v16.13.1
  • Windows, macOS, or Linux?: macOS
@zkochan
Copy link
Member

zkochan commented Jul 21, 2022

Why don't you use the new pnpm deploy command instead?

@jjangga0214
Copy link
Author

@zkochan Oh, is it a new command? Great!
I think providing the feature at a command level is very cool, especially for container images!

So, make-dedicated-lockfile is not supposed to be fixed from now on?
(there is also #5062 as well.)

Then I think the npm package should include a notification letting consumers know it's deprecated in favor of pnpm deploy.

How do you think?

P.S. However, I found an issue and left #5082.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants