fix: fix CoW in Windows #2
Conversation
|
@nachoaldamav Since you are the author of |
@KSXGitHub Yes, I'll change it |
|
I have also noticed that |
It's permissive, but I'm changing it to MIT, to avoid any issue |
Co-authored-by: Khải <hvksmr1996@gmail.com>
|
CI failed. Probably because of reference error caused by my suggestions failing to cover all necessary changes. |
Yes, I'm working on the other side |
|
@KSXGitHub is this correct? I don't know if the // Sync version
#[napi(js_name = "reflinkFileSync")]
pub fn reflink_sync(env: Env, src: String, dst: String) -> Result<JsNumber> {
let src_path = src.clone();
let dst_path = dst.clone();
match reflink_file_sync(src_path, dst_path) {
Ok(_) => Ok(env.create_int32(0)?),
Err(err) => Err(Error::from_reason(format!(
"{}, reflink '{}' -> '{}'",
err.to_string(),
src,
dst
))),
}
} |
|
@nachoaldamav Why didn't you pass it by reference? |
| let src_path = PathBuf::from(src); | ||
| let dst_path = PathBuf::from(dst); | ||
| AsyncTask::new(AsyncReflink { src: src_path, dst: dst_path }) | ||
| AsyncTask::new(AsyncReflink { src, dst }) | ||
| } | ||
|
|
||
| // Sync version | ||
| #[napi(js_name = "reflinkFileSync")] | ||
| pub fn reflink_sync(env: Env, src: String, dst: String) -> Result<JsNumber> { |
There was a problem hiding this comment.
I am not familiar with napi, can reflink_sync here can take &str as type for src and dst?
There was a problem hiding this comment.
I think it has to be String, maybe I'm missing something though https://napi.rs/docs/concepts/values.en#string
| @@ -46,15 +37,13 @@ impl Task for AsyncReflink { | |||
| // Async version | |||
| #[napi(js_name = "reflinkFile")] | |||
| pub fn reflink_task(src: String, dst: String) -> AsyncTask<AsyncReflink> { | |||
There was a problem hiding this comment.
This too. Can it take &str as parameter types?
Closes pnpm/pnpm#7186
This PR changes the package to create the reflinks from
reflink-copytocopy_on_write, on Unix it is still usingreflink-copyunderneath.In the
copy_on_writepackage I have fixed a bug that occurred in ReFS file systems where if you clone the same file to different destinations at the same time (multi-threading basically), the source was modified and filled with null bytes.The solution to this error is to open the source with the
FILE_FLAG_NO_BUFFERINGflag (microsoft/CopyOnWrite#12 (comment)).Also, one important thing, in https://github.com/nachoaldamav/CopyOnWrite I created some Github Actions to run the tests in the specific File systems we want to test, using Google Cloud VMs.