Skip to content
This repository has been archived by the owner on May 14, 2018. It is now read-only.

fix: introduce a class implementation of InstalledPackage interface #17

Closed
wants to merge 1 commit into from
Closed

Conversation

valotas
Copy link
Contributor

@valotas valotas commented Nov 18, 2017

No description provided.

Copy link
Member

@zkochan zkochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many changes. Only the pkg parameter should be changed to set only the needed set of fields.

pnpm is written using functional programming. There are no classes in it except the Error objects.

@zkochan
Copy link
Member

zkochan commented Nov 18, 2017

Actually, I checked the code. Even fewer properties are needed. I'll do this today.

@zkochan zkochan closed this in 15a5d34 Nov 18, 2017
@valotas
Copy link
Contributor Author

valotas commented Nov 18, 2017

I would like to fix the issues, but your are really fast!

@zkochan
Copy link
Member

zkochan commented Nov 18, 2017

I appreciate it! Have you tried your fix? Did it fix the issue with memory? Or you want to try the fix once pnpm gets published with it?

@valotas
Copy link
Contributor Author

valotas commented Nov 18, 2017

I can only try it on Monday as it is not a personal project.

@valotas valotas deleted the issue938 branch November 19, 2017 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants