Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0.2.0 release: include README.md that's missing from the package #12

Merged
merged 1 commit into from
Jan 5, 2015

Conversation

pimterry
Copy link
Contributor

@pimterry pimterry commented Jan 4, 2015

Sorry to keep opening issues!

The new 0.2.0 release doesn't install, because it needs a README.md file rather than README.rst, as of 9f302a4, and that file isn't included in the package itself. This adds it to the package.

I think this is correct, but I'm not actually really that familiar with Python packaging, so I'm basically guessing. Looks likely though, to my eye.

In case it's useful, the actual error is:

(venv)vagrant@vagrant-ubuntu-trusty-64:/vagrant$ pip install timeout-decorator                               
Collecting timeout-decorator                                                                                 
  Using cached timeout-decorator-0.2.0.tar.gz                                                                
    Traceback (most recent call last):                                                                       
      File "<string>", line 20, in <module>                                                                  
      File "/tmp/pip-build-01qb3sk9/timeout-decorator/setup.py", line 24, in <module>                        
        long_description = open('README.md').read(),                                                         
    FileNotFoundError: [Errno 2] No such file or directory: 'README.md'                                      
    Complete output from command python setup.py egg_info:                                                   
    Traceback (most recent call last):                                                                       

      File "<string>", line 20, in <module>                                                                  

      File "/tmp/pip-build-01qb3sk9/timeout-decorator/setup.py", line 24, in <module>                        

        long_description = open('README.md').read(),                                                         

    FileNotFoundError: [Errno 2] No such file or directory: 'README.md'                                      

    ----------------------------------------                                                                 
    Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-01qb3sk9/timeout-decorator 

The 0.2.0 release doesn't install, because it needs a README.md file rather than README.rst, as of pnpnpn@9f302a4, and the file isn't included in the package itself. This adds it to the package (I think).
@pnpnpn
Copy link
Owner

pnpnpn commented Jan 5, 2015

Oops. You are right. Thanks!

pnpnpn added a commit that referenced this pull request Jan 5, 2015
Fix 0.2.0 release: include README.md that's missing from the package
@pnpnpn pnpnpn merged commit c9bce2a into pnpnpn:master Jan 5, 2015
@pimterry pimterry deleted the patch-1 branch January 5, 2015 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants