Fix a bug when using a custom exception with a custom exception message. Also remove tests for Python 3.2 and 3.3. #55
Conversation
…eption message. Added a test for this condition.
|
Hmmm. I fixed the linter error And most of the tests pass now. The tests that fail seem to be failing due to the python version used for those tests, which doesn't seem to be caused by my code. So I think it's good now? I'm new to this system. |
tlalexander
changed the title
|
It looks like tox no longer supports python 3.2 and 3.3, so I've removed those from the tests. I base my understanding on the comment "tox fails (because setuptools has dropped support for Python 3.3 since v40.0.0)." From this page: Well... The test just completed as I was writing this comment, and it seems I failed to disable the tests in the way I had intended. I will try to see what I can do here, but perhaps this needs to be fixed by the project owner... |
|
Okay! Sorry I missed the .travis.yml as I was only looking in the command line with "ls" and the yml was hidden. Got it sorted! It does look like the tests for python 3.2 and 3.3 should be removed. Hopefully my changes look good. Thanks! |
|
lgtm. Can you please bump the version to |
|
Done. Thanks for the quick response! |
Fixes #54
Test included. I didn't see how to run the test so hopefully it just passes. :)