-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hidpi support #19
Conversation
How come things keep breaking for you when it comes to hidpi stuff x.x works without a problem for me with any scaling value, be it integer or fractional. |
I quickly check the possible values. If edit: |
Huh, 1.09 - 1.16 also breaks for me... that is so weird. Edit: Now I don't know what kind of sorcery is going on here, but but that makes absolutely no sense at all... |
|
e4ca9be
to
56b9e7d
Compare
With the rounding it works. No idea why my previous example didn't work, as 200*1.1 should still be a clean 220, and the output also didn't show any comma digits, but oh well. Thanks for finding that. Edit: I've been trying out a few things, inserting rounding in different places, and it makes less and less sense. Things that should be identical just don't work, sometimes the player even crashes. Maybe I'm missing something because I'm awfully tired. But what's important is that the commit above works. |
If your main mpv instance is crashing, or more accurately freezing, it's caused by an overlay-add stride parameter that doesn't match the thumbnail's size. |
I already suspected that it must be something like that, but I had rounding in But the commit above works reliably afaict, and that's what matters. |
In a mixed dpi setup, setting the resolution in the config is not sufficient for good results.