Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that the reordering attack on BinaryAgreement no longer succeeds #228

Closed
vkomenda opened this issue Sep 12, 2018 · 1 comment
Closed

Test that the reordering attack on BinaryAgreement no longer succeeds #228

vkomenda opened this issue Sep 12, 2018 · 1 comment
Labels
good first issue Good for newcomers test

Comments

@vkomenda
Copy link
Contributor

vkomenda commented Sep 12, 2018 •
edited

The reordering attack described in amiller/HoneyBadgerBFT#59 (comment) was avoided by adding Conf messages in #44, see also #37. We need a test that replays the attack and verifies that the attack does not succeed.

Closes #37.
Closes #45.
@vkomenda vkomenda added good first issue Good for newcomers test labels Sep 12, 2018
@afck afck mentioned this issue Oct 9, 2018
Closed
@d33a94975ba60d59
Copy link
Contributor

I'll take this issue.

@d33a94975ba60d59 d33a94975ba60d59 mentioned this issue Oct 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vkomenda @d33a94975ba60d59