Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Sign data and recover account pages styles fixes #174

Merged
merged 8 commits into from
Nov 6, 2018

Conversation

vbaranov
Copy link
Collaborator

Before:
screen shot 2018-10-30 at 17 43 00

After:
screen shot 2018-10-30 at 13 39 06

Also, react-hyperscript was rewritten with JSX for those pages.

The signing od data and recovering of account can be tested with https://danfinlay.github.io/js-eth-personal-sign-examples/

@dennis00010011b
Copy link

dennis00010011b commented Oct 31, 2018

@vbaranov
If account balance is zero then word 'None' is displayed instead zero
screen shot 2018-10-30 at 5 09 57 pm

Similar #155'

@vbaranov
Copy link
Collaborator Author

If account balance is zero then word 'None' is displayed instead zero

@dennis00010011b component fixed here #177

@dennis00010011b dennis00010011b mentioned this pull request Nov 1, 2018
@dennis00010011b
Copy link

@vbaranov
Screen 'Confirm transaction': incorrect background color for title and footer

screen shot 2018-11-01 at 10 51 36 am

@vbaranov
Copy link
Collaborator Author

vbaranov commented Nov 1, 2018

@dennis00010011b great catch! thanks. Fixed here 428b39d

@vbaranov vbaranov merged commit 686d1af into develop Nov 6, 2018
@ghost ghost removed the awaiting for review label Nov 6, 2018
@vbaranov vbaranov deleted the send-messages branch November 6, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants