(Fix) Remove MM warning and fix white pending tx page #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbaranov
added
logical bug
ghost
assigned 
|
Tests are successful eventually |
patitonar
approved these changes
Nov 9, 2018
dennis00010011b
approved these changes
Nov 9, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should create a request to get token's symbol and decimals, only for token transfer.
For now, it tries to get token's metadata for any type of pending tx, thereby, sometimes, it causes a white screen for pending tx page.
Also, MM warning about EIP-1102 implementation is removed.
@dennis00010011b @fvictorio @patitonar please take a look.
Should be merged to master and released as soon as possible.