This repository has been archived by the owner on Jun 29, 2020. It is now read-only.
Improve error handling in frontend #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@fvictorio @phahulin Please, if you can review it, and comment if you have any ideas. |
Pull Request Test Coverage Report for Build 158
💛 - Coveralls |
|
We should also emit a proper error if the contract is not deployed in the current network. I think this error will be thrown by the |
phahulin
reviewed
Aug 2, 2018
frontend/src/PoBA.js
Outdated
| this.setState({ registeredAccounts }) | ||
| this.setState({ registeredAccounts }) | ||
| } catch (e) { | ||
| console.error('There was a problem deploying the contract', e) |
There was a problem hiding this comment.
Let's change the error message to something like "Contract is not deployed on this network".
frontend/src/PoBA.js
Outdated
|
|
||
| const registeredAcountsCount = await this.pobaContract.accountsLength.call(account) | ||
| const registeredAcountsCount = await this.pobaContract.accountsLength.call(account) |
There was a problem hiding this comment.
There's a typo in variable name, should be registeredAccountsCount
phahulin
approved these changes
Aug 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36