This repository has been archived by the owner on Jun 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Improve error handling in frontend #60
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
090cc83
Add one alert
garatortiz fc4ed46
Add eslintignore to blockchain
garatortiz 7a99065
Fix linter
garatortiz 1b4ee32
Change the title of the alerts
garatortiz 96f955c
Show alert error if the contract was not deployed
garatortiz 88324de
Fix typo and update error message
garatortiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
coverage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,30 +46,41 @@ class PoBA extends Component { | |
|
||
PobaContract.setProvider(web3.currentProvider) | ||
|
||
this.pobaContract = await PobaContract.deployed() | ||
try { | ||
this.pobaContract = await PobaContract.deployed() | ||
|
||
const registeredAcountsCount = await this.pobaContract.accountsLength.call(account) | ||
const registeredAcountsCount = await this.pobaContract.accountsLength.call(account) | ||
|
||
const whenAccounts = [] | ||
for (let i = 0; i < registeredAcountsCount; i++) { | ||
whenAccounts.push(this.pobaContract.accounts(account, i)) | ||
} | ||
const whenAccounts = [] | ||
for (let i = 0; i < registeredAcountsCount; i++) { | ||
whenAccounts.push(this.pobaContract.accounts(account, i)) | ||
} | ||
|
||
const registeredAccounts = await Promise.all(whenAccounts) | ||
const registeredAccounts = await Promise.all(whenAccounts) | ||
|
||
this.setState({ registeredAccounts }) | ||
this.setState({ registeredAccounts }) | ||
} catch (e) { | ||
console.error('There was a problem deploying the contract', e) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's change the error message to something like "Contract is not deployed on this network". |
||
errorAlert('There was a problem deploying the contract') | ||
} | ||
} | ||
|
||
fetchBankAccounts = async token => { | ||
this.setState({ loading: true }) | ||
|
||
return getBankAccounts(token) | ||
.then(bankAccounts => { | ||
this.setState({ | ||
token, | ||
bankAccounts | ||
}) | ||
}) | ||
.then( | ||
bankAccounts => { | ||
this.setState({ | ||
token, | ||
bankAccounts | ||
}) | ||
}, | ||
e => { | ||
console.error('There was a problem getting the bank accounts', e) | ||
errorAlert('There was a problem getting the bank accounts') | ||
} | ||
) | ||
.finally(() => this.setState({ loading: false })) | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in variable name, should be registeredAccountsCount