Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Soft keyboard issue in Android #36

Merged
merged 16 commits into from
Aug 19, 2022
Merged

Fix: Soft keyboard issue in Android #36

merged 16 commits into from
Aug 19, 2022

Conversation

pobch
Copy link
Owner

@pobch pobch commented Aug 18, 2022

Why?

We already fixed soft keyboard issue in iOS:

By the way, things are difference in Android:
image
Android: document.documentElement got resized when the soft keyboard appears
iOS: document.documentElement maintains the size even though the soft keyboard appears

How?

  • Remove resize event listener. No more auto-resize the canvas while the screen size is changing.
  • Set the canvas width/height only once at the first render
  • In case the screen size changes, a user needs to manually click a button to recalculate the canvas width/height

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for react-diagram ready!

Name Link
🔨 Latest commit 59c2845
🔍 Latest deploy log https://app.netlify.com/sites/react-diagram/deploys/62fff8ac044e0000082afc93
😎 Deploy Preview https://deploy-preview-36--react-diagram.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pobch pobch added bug Something isn't working WIP Work in progress labels Aug 18, 2022
@pobch pobch removed the WIP Work in progress label Aug 19, 2022
@pobch pobch merged commit aeffc1a into master Aug 19, 2022
@pobch pobch deleted the bug-soft-keyboard2 branch August 19, 2022 21:12
@pobch pobch added the documentation Improvements or additions to documentation label Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant