Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] migrate to 0.46.1 not working #9

Closed
fifiteen82726 opened this issue May 15, 2017 · 3 comments
Closed

[BUG] migrate to 0.46.1 not working #9

fifiteen82726 opened this issue May 15, 2017 · 3 comments
Assignees

Comments

@fifiteen82726
Copy link

fifiteen82726 commented May 15, 2017

Here is my .rubocop.yml

Style/MethodCallParentheses:
  Description: 'Do not use parentheses for method calls with no arguments.'
  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-args-no-parens'
  Enabled: false
  • When I type mry --target=0.46.1 .rubocop.yml
    The .rubocop.yml didn't change.

  • When I type mry --target=0.48.0 .rubocop.yml
    It become

Style/MethodCallWithoutArgsParentheses:
  Description: 'Do not use parentheses for method calls with no arguments.'
  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-args-no-parens'
  Enabled: false

So, when I type mry --target=0.46.1 .rubocop.yml again, it should become the original one.

But it still be the altered one, which is

Style/MethodCallWithoutArgsParentheses:
  Description: 'Do not use parentheses for method calls with no arguments.'
  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-args-no-parens'
  Enabled: false
@fifiteen82726 fifiteen82726 changed the title migrate to 0.46.1 not working [BUG] migrate to 0.46.1 not working May 15, 2017
@pocke pocke self-assigned this May 15, 2017
@pocke
Copy link
Owner

pocke commented May 15, 2017

Thanks for the reporting!

Currently mry doesn't support downgrading RuboCop version. So, mry can't replace 0.48.0 with 0.46.1.

I'll implement this feature.

pocke added a commit that referenced this issue May 15, 2017
@pocke pocke closed this as completed in #10 May 15, 2017
@pocke
Copy link
Owner

pocke commented May 15, 2017

I've fixed and released v0.48.1.3. https://github.com/pocke/mry/releases/tag/v0.48.1.3

Thanks

@fifiteen82726
Copy link
Author

@pocke What an efficiency! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants