Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong install location for cmake config files on Ubuntu #3244

Closed
Krzmbrzl opened this issue Apr 16, 2021 · 14 comments
Closed

Wrong install location for cmake config files on Ubuntu #3244

Krzmbrzl opened this issue Apr 16, 2021 · 14 comments
Labels
bug buildsystem cmake Related to cmake build system

Comments

@Krzmbrzl
Copy link

First off: I am not entirely sure whether this is an issue with Poco itself or only with the way it now gets packaged on recent versions of Ubuntu.

Trying to locate the Poco libraries via a regular find_package command fails starting from Ubuntu Groovy (20.10). It still works fine on Ubuntu focal (20.04).

find_package(Poco COMPONENTS Zip)

Presumably this is because in 20.04, the cmake config files are installed to e.g. /usr/lib/cmake/Poco/PocoConfig.cmake (source) whereas on 20.10, they are installed to /usr/lib/x86_64-linux-gnu/cmake/cmake/Poco/PocoConfig.cmake(source). Note the cmake/cmake part in that path, which I believe is one cmake dir too much for it to work.

Did you perhaps make any changes to the install locations that could have caused this issue or is this something the Ubuntu packagers have changed on their own?

@obiltschnig obiltschnig added buildsystem cmake Related to cmake build system labels Apr 17, 2021
@Bjoe
Copy link
Contributor

Bjoe commented Apr 21, 2021

@Krzmbrzl Right, this is the wrong directory

I must verify on which site this is going wrong....

@Bjoe
Copy link
Contributor

Bjoe commented Apr 21, 2021

It might be, this is the problem we set PocoConfigPackageLocation
We should not do this. The correct location is set by cmake. Cmake know on which platform it is building the project and put the config-moduls in the correct directory.
But I need to verify this. Btw. the debian package has also some interesting patches :-)

@jayvdb
Copy link
Contributor

jayvdb commented Nov 26, 2021

I've noted this problem in debian bugreport 1000656 along with another problem effecting Debian/Ubuntu/etc wrt cmake finding pcre.

@jspricke
Copy link
Contributor

This should be fixed in 1.11.0-3 in Debian unstable. Sorry for the trouble.

@jayvdb
Copy link
Contributor

jayvdb commented Nov 27, 2021

@jspricke , I think the pcre problem reported in debian bugreport 1000656 is yet to be addressed. One solution is to install https://github.com/pocoproject/poco/blob/master/cmake/FindPCRE.cmake in the Poco cmake directory.

Also https://packages.debian.org/sid/libpoco-dev is still showing 1.11.0-2, containing the double cmake/cmake path in /usr/lib/x86_64-linux-gnu/cmake/cmake/Poco. Is that because of the pipeline failure at https://salsa.debian.org/debian/poco/-/pipelines/318257 , or just a usual delay in the new release propagating to all the various systems?

@jspricke
Copy link
Contributor

jspricke commented Nov 27, 2021 via email

@jayvdb
Copy link
Contributor

jayvdb commented Nov 27, 2021

Tested. Both are now fixed! Thanks @jspricke !

@jayvdb
Copy link
Contributor

jayvdb commented Nov 28, 2021

Can we expect this might make it into stable(bullseye), where libpoco-dev is at 1.10.0-6?

@jspricke
Copy link
Contributor

jspricke commented Nov 28, 2021 via email

@jayvdb
Copy link
Contributor

jayvdb commented Dec 10, 2021

@jspricke , it looks like you have the green light.

@jspricke
Copy link
Contributor

Yes, it was already accepted: https://release.debian.org/proposed-updates/stable.html
And will be part of the next stable release point release on the 18.: https://release.debian.org/

@jayvdb
Copy link
Contributor

jayvdb commented Dec 10, 2021

Thanks for the links - I'm slowly learning the debian processes ;-)

@jspricke
Copy link
Contributor

Btw. as the initial bug report was for Ubuntu, maybe someone wants to fill a SRU: https://wiki.ubuntu.com/StableReleaseUpdates

@jayvdb
Copy link
Contributor

jayvdb commented Dec 20, 2021

Now in Debian stable and Ubuntu jammy.
I guess this can be closed now, unless this ticket also wants to track it drifting into a stable Ubuntu.

@aleks-f aleks-f closed this as completed Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buildsystem cmake Related to cmake build system
Projects
None yet
Development

No branches or pull requests

6 participants