Feature/issue-110 #117
Merged
Feature/issue-110 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nlenssen2013 Can you merge develop into this PR and retest? Just to make sure it's all good. |
jamesfwood
approved these changes
Sep 14, 2022
|
Merge when you are ready |
jamesfwood
added a commit
that referenced
this pull request
Oct 18, 2022
* /version 2.2.0-alpha.0 * Feature/issue 85 (#112) * Add initial poetry setup guidance to the README * Update CHANGELOG "unreleased" with issue 85 * Adding collections UAT: C1242387621-POCLOUD * Adding collections UAT: C1238658389-POCLOUD * Feature/issue 115 (#116) * make note in README of `-E harmony` install option for tests * Update CHANGELOG.md Co-authored-by: dkaufma3 <daniel.kaufman@nasa.gov> * Adding collections OPS: C2152045877-POCLOUD * Feature/issue-110 (#117) * Add extra line of logic to catch timedelta time cases * Updated Changelog * Add logic to handle time attributes for he5 time converted files * Linted code * Feature/issue 119 (#120) * Add extra line of logic to catch timedelta time cases * Updated Changelog * Add logic to handle time attributes for he5 time converted files * Linted code * Added extra logic for compute time vars for cases without any variables * change back chunking * Update Changelog * Feature/issue 122 (#123) * Add extra line of logic to catch timedelta time cases * Updated Changelog * Add logic to handle time attributes for he5 time converted files * Linted code * Fix for ncdataset rename deprication - test writing to follow * Remove unnecessary comments, changing to issue 119 * Added test and linted for duplicate dimension name change * Updated Changelog.md * Release 2.2.0 * /version 2.2.0-rc.1 * Updated to rc.2 * /version 2.2.0-rc.3 Co-authored-by: l2ss-py bot <l2ss-py@noreply.github.com> Co-authored-by: Daniel Kaufman <dkauf42@users.noreply.github.com> Co-authored-by: podaac-cloud-dsa <podaac-cloud-dsa@jpl.nasa.gov> Co-authored-by: Frank Greguska <89428916+frankinspace@users.noreply.github.com> Co-authored-by: dkaufma3 <daniel.kaufman@nasa.gov> Co-authored-by: James Wood <James.F.Wood@jpl.nasa.gov> Co-authored-by: Nick Lenssen <nicklenssen4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #110
Description
If time for he5 files are decoded manually, then they also need to be coded back into the output with the same attributes as the input. Xarray will decode times into seconds since the first timestamp rather than seconds since 1993 for these cases
Overview of work done
Start date is returned from convert_times method, it is either the start date or None. If there is a date, then in the recombine grouped datasets method through the _rename variables method - the times will be decoded
Overview of verification done
Unittest that compares the time attributes for OMI files before and after subsetting
Overview of integration done
Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request