[enh] update to nextjs 14 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
marco-souza
force-pushed
the
marco/nextjs-14
branch
from
62fe9e1 to
bc0301b
Compare
marco-souza
commented
Jun 28, 2024
marco-souza
force-pushed
the
marco/nextjs-14
branch
from
177a010 to
166bd3b
Compare
5 tasks
|
|
frattezi
approved these changes
Jun 29, 2024
| <Component {...pageProps} /> | ||
| </Layout>, | ||
| providers, | ||
| const isClient = useIsClient(); |
There was a problem hiding this comment.
This is too queiiizy. Can we refactor that and use correct server/client side component composition to avoid this types of checks?
We can schedule a task for that.
There was a problem hiding this comment.
@frattezi We can, but it'd require some refactoring. I'm planning to move to tailwind + daisy-ui in an upcoming PR
- nextjs - react & react-doom - typescript
marco-souza
force-pushed
the
marco/nextjs-14
branch
from
2e78ca3 to
8535e1d
Compare
marco-souza
added a commit
that referenced
this pull request
Jul 2, 2024
* fea: setup biome * fix: yarn fmt * ref: remove lottie related files * ref: format everything * fix: remove prettier * fix: remove eslint * fix: yarn build * fix: tab size * fix: playwright * enh: update gh action * enh: update ci * fix: ci * oth: fmt * fix: adjust biome spacing * fix: run fmt * [enh] update to nextjs 14 (#162) * enh: upgrade packages - nextjs - react & react-doom - typescript * enh: upgrade ts * fix: ssr rendering issue * fix: fmt * enh: run playwright tests on prs * enh: playwright test * enh: run playwright tests for all PRs * fix: next export * fix: remove export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição
This PR upgrades a few packages
Changes
TODO
src/appThis closes #160