Skip to content

Conversation

trygve-lie
Copy link
Contributor

This restricts the possibility to have a origin as a value to the pathname. There is no real use case for being able to do so. Ref: https://nodejs.org/api/url.html#url-strings-and-url-objects

Iow: previously one could do as follow:

utils.pathnameBuilder('/foo', 'https://bar.com', '/xyz');

Which would yeld a pathname as follow: /foo/https://bar.com/xyz. And that does not make any sense.

Copy link
Member

@digitalsadhu digitalsadhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Question included for my own musings

@trygve-lie trygve-lie merged commit ff9785d into master Oct 26, 2021
@trygve-lie trygve-lie deleted the restrict-pathname branch October 26, 2021 13:37
github-actions bot pushed a commit that referenced this pull request Oct 26, 2021
## [4.4.27](v4.4.26...v4.4.27) (2021-10-26)

### Bug Fixes

* Do not allow origin as a pathname value ([#143](#143)) ([ff9785d](ff9785d))
@github-actions
Copy link

🎉 This PR is included in version 4.4.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request May 3, 2022
# [5.0.0-next.7](v5.0.0-next.6...v5.0.0-next.7) (2022-05-03)

### Bug Fixes

* **deps:** update dependency @podium/schemas to v4.1.16 ([c47f0bf](c47f0bf))
* **deps:** update dependency @podium/schemas to v4.1.17 ([b45e56d](b45e56d))
* **deps:** update dependency @podium/schemas to v4.1.18 ([21ef50a](21ef50a))
* **deps:** update dependency @podium/schemas to v4.1.19 ([3a4f6a8](3a4f6a8))
* **deps:** update dependency @podium/schemas to v4.1.20 ([7d9955b](7d9955b))
* **deps:** update dependency @podium/schemas to v4.1.21 ([cebdc13](cebdc13))
* **deps:** update dependency @podium/schemas to v4.1.22 ([15d8ea9](15d8ea9))
* **deps:** update dependency @podium/schemas to v4.1.23 ([c18698a](c18698a))
* **deps:** update dependency @podium/schemas to v4.1.24 ([35c41c7](35c41c7))
* **deps:** update dependency @podium/schemas to v4.1.25 ([27b8507](27b8507))
* **deps:** update dependency @podium/schemas to v4.1.26 ([961e0e0](961e0e0))
* **deps:** update dependency @podium/schemas to v4.1.27 ([72d4596](72d4596))
* **deps:** update dependency @podium/schemas to v4.1.28 ([b3d9275](b3d9275))
* **deps:** update dependency @podium/schemas to v4.1.29 ([cc43020](cc43020))
* **deps:** update dependency @podium/schemas to v4.1.30 ([3a390ce](3a390ce))
* **deps:** update dependency @podium/schemas to v4.1.31 ([2f67490](2f67490))
* **deps:** update dependency @podium/schemas to v4.1.32 ([0322287](0322287))
* **deps:** update dependency camelcase to v6.2.1 ([2f9a3e3](2f9a3e3))
* **deps:** update dependency camelcase to v6.3.0 ([fee3e49](fee3e49))
* Do not allow origin as a pathname value ([#143](#143)) ([ff9785d](ff9785d))
@github-actions
Copy link

github-actions bot commented May 3, 2022

🎉 This PR is included in version 5.0.0-next.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants